jhen0409/react-native-debugger

CMD+R shortcut is conflicting with main Chrome app

Open

#618 opened on Jun 1, 2021

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (10,097 stars) (850 forks)batch import
bughelp wanted

Description

I was being driven crazy by the fact that Chrome CMD+R suddenly stopped working and no matter what I did, incognito mode, disabling all extensions, nothing would make it work again.

Then searching on the Internet I found that perhaps some other application was conflicting with it and downloaded ShortcutDetective, and bingo! It was that. It reported that the React Native Debugger app was listening to the event, even though it was in the background and I had Chrome focused.

I realize that this might be a quirk behavior due to the fact that RN debugger uses Chrome Devtools under the hood, but I haven't ever had this problem occur with the DevTools of Chrome itself (reload being hijacked when it's not focused).

React Native Debugger app version: 0.11.8 React Native version: 0.64.1 Platform: iOS, Android Is real device of platform: Yes Operating System: macOS

Contributor guide

Tech stack
electronjavascriptreactreact native
Domain
desktopdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of ElectronUnderstanding of keyboard event handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the Electron main process where global shortcuts are registered. Look for the registration of CMD+R in the app's menu or globalShortcut module. Consider conditionally registering the shortcut only when the app is focused, similar to how Chrome DevTools handles it. Review the source files in the 'electron' directory, specifically 'main.ts' or 'menu.ts', and any global shortcut configuration. Check linked comments for any proposed fixes.