jfmengels/node-elm-review

Report error when running with "suppress --watch"

Open

#94 opened on Dec 17, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Elm (27 forks)github user discovery
good first issue

Repository metrics

Stars
 (55 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

When we run elm-review suppress --watch, the tool currently just does a review, not a suppression.

I don't think this combination makes sense (feedback or use-cases welcome!) so we should report an error if both are used together.

Contributor guide

Research direction
Add a condition to detect when both 'suppress' and 'watch' flags are used together and output an error message.
Tech stack
nodejs
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85