jfmengels/eslint-plugin-lodash-fp

`prefer-composition` rule

Open

#4 opened on Apr 14, 2016

View on GitHub
 (0 comments) (1 reaction) (0 assignees)JavaScript (24 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (150 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Use composition methods (_.compose, _.flow, ...) instead of chaining multiple map/filter/reduce/... array methods

a.map(fn1).filter(fn2).every(fn3);
// -->
_.flow(_.map(fn1), _.filter(fn2), _.every(fn3))(a);
// or
_.compose(_.every(fn3), _.filter(fn2), _.map(fn1))(a);

In the documentation, there should be a section saying that this should probably not be used with projects that use Observables, as it will create a lot of false positives.

Contributor guide

Research direction
Study the existing rule patterns in the plugin, understand AST for CallExpression and MemberExpression, implement an ESLint rule that detects chaining of map/filter/reduce etc. and suggests using .flow or .compose. Include documentation and test cases.
Tech stack
javascript
Domain
developer experiencetooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptESLintlodash/fp
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70