jfmengels/eslint-plugin-fp

no-nil doesn't seem to understand default switch case

Open

#14 opened on Oct 15, 2016

View on GitHub
 (10 comments) (8 reactions) (0 assignees)JavaScript (35 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (968 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

const reducer = (state = {}, action) => {
  switch (action.type) {
    case 'CHANGE_TEXT':
      return { text: action.payload };
    default:
      return state;
  }
};

This function will always return something, but sadly I get the error Function must end with a return statement, so that it doesn't return undefined fp/no-nil.

Contributor guide

Research direction
Inspect the implementation of the `no nil` rule to understand how it handles `switch` statements with a `default` case. Trace the logic that checks for return statements and ensure the `default` case is considered as a valid termination point.
Tech stack
javascript
Domain
devtools
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptESLint
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65