jfmengels/elm-review-simplify

String.join / String.concat with a single element

Open

#336 opened on Jan 18, 2025

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Elm (10 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (22 stars)
PR merge metrics
 (PR metrics pending)

Description

What the rule should do: String.join "foo" [ a ] => a String.concat [ a ] => a

Example of things the rule would not report:

String.join "foo" [ "bar", "baz" ]
String.concat [ "bar", "baz" ]

Should this be part of the Simplify rule or should it be a new rule? Part of Simplify

I am looking for:

  • Someone to implement it with/for me

Contributor guide

Research direction
Locate the Simplify rule module in the repository (likely 'src/Simplify.elm' or similar) and add cases for 'String.join' with a single element list and 'String.concat' with a single element list. The rule should replace such calls with the single element itself.
Tech stack
None
Domain
tooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ElmGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65