jfmengels/elm-review-simplify

Remove duplicate entries in Set.fromList/Dict.fromList

Open

#326 opened on Dec 13, 2024

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Elm (10 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (22 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

If some of the keys are the same, then we can remove some of them (potentially telling the user there's a problem with their setup).

Dict.fromList [ ( 1, a ), ( 2, b ), ( 3, c ), ( 1, d ) ]
--> ✔
Dict.fromList [ ( 2, b ), ( 3, c ), ( 1, d ) ]

Dict.fromList [ ( 1, a ), ( 2, b ), ( 3, c ) ]
  |> Dict.insert 1 d
-->
Dict.fromList [ ( 2, b ), ( 3, c ) ]
  |> Dict.insert 1 d
--> Or alternatively put it directly in the list, probably nicer
Dict.fromList [ ( 2, b ), ( 3, c ), ( 1, d ) ]


Set.fromList [ 1, 2, 3, 1 ]
--> ✔
Set.fromList [ 2, 3, 1 ]
--> or remove the later one 🤷 
Set.fromList [ 1, 2, 3 ]

Set.fromList [ 1, 2, 3 ]
  |> Set.insert 1
-->
Set.fromList [ 1, 2, 3 ]

Contributor guide

Research direction
Explore the current implementation of Dict.fromList and Set.fromList in the elm review simplify codebase, identify where duplicates should be removed, and decide whether to keep the first or last occurrence.
Tech stack
None
Domain
developer experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Elmelm review
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70