jfmengels/elm-review-simplify

Simplify Dict.get comparison with Maybe to Dict.member

Open

#324 opened on Dec 2, 2024

View on GitHub
 (0 comments) (1 reaction) (0 assignees)Elm (10 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (22 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Dict.get x dict /= Nothing
--> Dict.member x dict

Dict.get x dict == Nothing
--> not (Dict.member x dict)

Contributor guide

Research direction
Implement a new elm review rule that detects `Dict.get x dict /= Nothing` and suggests `Dict.member x dict`. Study existing similar rules in the project for pattern matching and AST traversal.
Tech stack
None
Domain
developer experiencetooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Elmelm review
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65