jfmengels/elm-review-simplify

Removes thunk in decoder, causes infinite loop

Open

#318 opened on Aug 24, 2024

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Elm (10 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (22 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hello! I've found a corner case when simplifying decoders.

The above simplification looks fine at first glance. The problem is that it actually changes the meaning of the code. There's a reason this decoder was written this way, using a thunk: this snippet of code lives inside the compose function, and after simplification, it will cause the function to recursively call itself in an infinite loop.

Contributor guide

Research direction
Examine the simplification rule for decoders to ensure that thunks are only removed when it is safe to do so, preventing infinite recursion.
Tech stack
None
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Elm
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65