jfmengels/elm-review-simplify

Merging of let..in can lead to naming collisions

Open

#313 opened on Jun 26, 2024

View on GitHub
 (0 comments) (1 reaction) (0 assignees)Elm (10 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (22 stars)
PR merge metrics
 (PR metrics pending)

Description

SSCCE

value =
  let
    a name = name
  in
  let
    name = "str"
  in
  a name

Currently, this gets simplified to the following, which introduces a naming collision error from the compiler.

value =
  let
    a name = name

    name = "str"
  in
  a name

I think the solution would be to check that there will be no collisions, but this is quite a bit of analysis compared to what is done today. I wonder if there's a smart way of doing it :thinking:

Contributor guide

Research direction
Understand how let..in expressions are simplified and implement collision detection before merging.
Tech stack
None
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ElmGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65