jfmengels/elm-review-simplify

More List.minimum/maximum simplifications

Open

#306 opened on Apr 16, 2024

View on GitHub
 (2 comments) (2 reactions) (0 assignees)Elm (10 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (22 stars)
PR merge metrics
 (PR metrics pending)

Description

List.minimum [ 1, 2, 3 ]
--> Just 1
List.minimum (1 :: [ 2, 3 ])
--> Just 1

List.maximum [ 1, 2, 3 ]
--> Just 3

List.minimum [ a, 1 ]
-- Not reported, but if there are duplicate values, then we can remove some of them
List.minimum [ 3, a, 1 ]
--> List.minimum [ a, 1 ]
List.minimum (3 :: list ++ [5])
--> List.minimum (3 :: list)
List.minimum ([3] ++ list ++ [5])
--> List.minimum ([3] ++ list)

List.minimum (List.repeat <positiveInt> x)
--> Just x
List.maximum (List.repeat <positiveInt> x)
--> Just x

If we know x <= y

List.minimum (List.range x y)
--> Just x ✅
List.maximum (List.range x y)
--> Just y ✅

Contributor guide