jfmengels/elm-review-simplify

Rule enhancement: Don't do unnecessary destructuring

Open

#29 opened on Jul 20, 2022

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Elm (10 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (22 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

What the rule should do:

What problems does it solve:

Example of things the rule would report:

view (Model model) =
   div []
    [ viewA (Model model)
    , viewB (Model model)
    ]
-->
view model =
   div []
    [ viewA model
    , viewB model
    ]

Example of things the rule would not report:

view (Model model) =
   div []
    [ viewA (Model model)
    , viewB model -- using the extracted model
    , viewC model.x -- also using the extracted model
    ]

Should this be part of the Simplify rule or should it be a new rule?

I think it could be part of the Simplify rule.

I am looking for:

Someone to work on this :)

Contributor guide

Research direction
Study the Simplify rule structure and implement a new inspection for unnecessary destructuring in function arguments.
Tech stack
None
Domain
developer experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ElmGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60