jfmengels/elm-review-simplify

Simplify `if x then True else y` to `x || y`

Open

#12 opened on Jul 19, 2021

View on GitHub
 (8 comments) (0 reactions) (0 assignees)Elm (10 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (22 stars)
PR merge metrics
 (PR metrics pending)

Description

Stumbled across it in my (old, shameful) code the other day, but the following simplifications could be added:

if foo then
    True
else
    bar

to

foo || bar

and similarly

if foo then
    bar
else
    False

to

foo && bar

Should be easy to implement if you agree they should be, but don't want to put time into it if you disagree. :smile:

Contributor guide

Research direction
Look at the existing simplification rules in the codebase (e.g., Simplify.elm) to understand the pattern matching and AST transformation. Then add new cases for `if x then True else y` to `x || y` and `if x then y else False` to `x && y`.
Tech stack
None
Domain
tooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Elm
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75