jetty/jetty.project

Why there is no Regex Support for excludeList of nonProxyHost

Open

#8329 opened on Jul 22, 2022

View on GitHub
 (10 comments) (0 reactions) (1 assignee)Java (3,701 stars) (1,913 forks)batch import
EnhancementHelp Wanted

Description

Code at line below should be enhanced: https://github.com/eclipse/jetty.project/blob/8102378e2d24b8117ed3a545c7579f79d35fc45a/jetty-client/src/main/java/org/eclipse/jetty/client/ProxyConfiguration.java#L180

Generally nonProxyHosts gets defined with wildcards like *.abc.com|*.svc.local etc.. so .equals doesn't help ! And apparently Jetty Client doesn't have any support for wildcard list of nonProxyHosts !!

PS: reactor-netty handles it pretty well, refer below: https://github.com/reactor/reactor-netty/blob/main/reactor-netty-core/src/main/java/reactor/netty/transport/ProxyProvider.java#L310

Contributor guide

Tech stack
java
Domain
backendapi
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
needs maintainer response
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaHTTP proxy concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
The issue requests adding regex/wildcard support for nonProxyHosts in Jetty Client. The file to modify is ProxyConfiguration.java (line 180). Currently, it uses .equals() which fails for wildcard patterns like *.abc.com. A solution could implement pattern matching similar to reactor netty's ProxyProvider. Review the linked reactor netty code for reference. Discuss with maintainers about the desired pattern syntax and compatibility.