jetty/jetty.project

Why there is no Regex Support for excludeList of nonProxyHost

Open

#8,329 opened on Jul 22, 2022

View on GitHub
 (10 comments) (0 reactions) (1 assignee)Java (1,913 forks)batch import
EnhancementHelp Wanted

Repository metrics

Stars
 (3,701 stars)
PR merge metrics
 (Avg merge 6d 14h) (48 merged PRs in 30d)

Description

Code at line below should be enhanced: https://github.com/eclipse/jetty.project/blob/8102378e2d24b8117ed3a545c7579f79d35fc45a/jetty-client/src/main/java/org/eclipse/jetty/client/ProxyConfiguration.java#L180

Generally nonProxyHosts gets defined with wildcards like *.abc.com|*.svc.local etc.. so .equals doesn't help ! And apparently Jetty Client doesn't have any support for wildcard list of nonProxyHosts !!

PS: reactor-netty handles it pretty well, refer below: https://github.com/reactor/reactor-netty/blob/main/reactor-netty-core/src/main/java/reactor/netty/transport/ProxyProvider.java#L310

Contributor guide

Research direction
Examine the current ProxyConfiguration.java implementation, understand how nonProxyHosts are matched, and add a regex based matching mechanism similar to reactor netty's ProxyProvider.
Tech stack
java
Domain
backendapi
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45