jetty/jetty.project

MonitoredQueuedThreadPool should monitor tryExecute()

Open

#5827 opened on Dec 18, 2020

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Java (3,701 stars) (1,913 forks)batch import
Help WantedLow PriorityPinned

Description

Jetty version 9.4.x

Description MonitoredQueuedThreadPool does not "wrap" tryExecute(Runnable) like it wraps execute(Runnable), and therefore statistics are incomplete (or completely lacking) when the pool is in EPC mode.

Contributor guide

Tech stack
java
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Javathread pool basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the MonitoredQueuedThreadPool class, specifically the execute and tryExecute methods. The execute method has monitoring wrappers, while tryExecute does not. The goal is to add similar monitoring to tryExecute. Look at how execute wraps the Runnable to increment counters or record stats, and replicate that pattern for tryExecute. Check the associated test files for existing monitoring tests to understand expected behavior.