jetty/jetty.project

jetty-unixsocket: No ability to set permissions on unix domain socket - other services cannot connect

Open

#10860 opened on Nov 6, 2023

View on GitHub
 (16 comments) (0 reactions) (0 assignees)Java (3,701 stars) (1,913 forks)batch import
BugHelp Wanted

Description

Jetty version(s)

Jetty 10+

Jetty Environment

Java version/vendor (use: java -version)

openjdk version "17.0.9" 2023-10-17 LTS OpenJDK Runtime Environment (Red_Hat-17.0.9.0.9-1) (build 17.0.9+9-LTS) OpenJDK 64-Bit Server VM (Red_Hat-17.0.9.0.9-1) (build 17.0.9+9-LTS, mixed mode, sharing)

OS type/version

RHEL9

Description

When a unix domain socket is created, the socket is created given the umask of the server. This in almost all cases creates a socket that can only be connected to by the same user that runs jetty.

[root@seawitch ~]# ls -al /tmp/jenkins.socket 
srwxr-xr-x. 1 jenkins jenkins 0 Nov  6 22:08 /tmp/jenkins.socket

This breaks the privilege separation between components.

The workaround is to change the umask to 0002 or 0007, but this has the side effect that it gives full application write access to the entity connecting to the socket.

The permissions on the socket need to be configurable. No need to overthink the difference between unix and windows, if "allow anyone to connect" is allowed, the admin is given the option to put the sock in a directory protected as they need it.

How to reproduce?

Create a jenkins instance with unix domain socket support. See the permissions on the socket.

Contributor guide

Tech stack
java
Domain
backendsecurity
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Java programmingUnix domain socketsJetty internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue requests adding a configuration option to set the file permissions (e.g., 0660) on the Unix domain socket created by Jetty. The relevant code is likely in the jetty unixsocket module, specifically in classes like UnixSocketConnector. The maintainers have discussed the need for a getter/setter for permissions. Contributors should review the comments for design suggestions and then implement a new configuration property, ensuring backward compatibility.