jestjs/jest

Jest should resolve its dependencies from its own location rather than rootDir

Open

#5913 opened on Apr 3, 2018

View on GitHub
 (21 comments) (30 reactions) (0 assignees)TypeScript (45,361 stars) (6,653 forks)batch import
ConfirmedHelp WantedPinned

Description

Create React App users bumped into this issue recently. A third party package started depending on jest-validate, and that caused npm to hoist jest-environment-node to the top of the app tree. Unfortunately, Jest resolves environment package from the project root instead of from its own Node module location so as a result, it loads the wrong (hoisted) jest-environment-node.

I think the jest package should resolve any own dependencies from its own location (just like Node resolution works) rather than from the project root folder.

Contributor guide

Tech stack
javascripttypescriptnodejs
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Node.js module resolutionJest internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Examine the resolution logic in packages/jest config/src/utils.js around lines 109-111. Understand how the environment package is resolved from the project root. Investigate using require.resolve from Jest's own directory (e.g., dirname) to fix hoisting issues. Review the linked CRA issue for additional context. Ensure no breaking changes to other dependency resolutions.