jestjs/jest

Jest should resolve its dependencies from its own location rather than rootDir

Open

#5,913 opened on Apr 3, 2018

View on GitHub
 (21 comments) (30 reactions) (0 assignees)TypeScript (6,653 forks)batch import
ConfirmedHelp WantedPinned

Repository metrics

Stars
 (45,361 stars)
PR merge metrics
 (Avg merge 11d 22h) (11 merged PRs in 30d)

Description

Create React App users bumped into this issue recently. A third party package started depending on jest-validate, and that caused npm to hoist jest-environment-node to the top of the app tree. Unfortunately, Jest resolves environment package from the project root instead of from its own Node module location so as a result, it loads the wrong (hoisted) jest-environment-node.

I think the jest package should resolve any own dependencies from its own location (just like Node resolution works) rather than from the project root folder.

Contributor guide

Research direction
Investigate how Jest resolves its own dependencies, specifically looking at the function in packages/jest config/src/utils.js that resolves the environment package. Understand Node's module resolution algorithm and determine if the fix should change the resolution to start from Jest's own location.
Tech stack
javascriptnodejs
Domain
testing
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Node.jsnpm
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65