jest-community/jest-runner-eslint

Yarn workspaces

Open

#41 opened on Apr 25, 2018

View on GitHubContributor guide
 (7 comments) (0 reactions) (0 assignees)JavaScript (48 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (481 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

The module resolver looking for your local eslint installation seems not to be compatible with yarn workspaces.

It apparently only looks into the ./node_modules folder in the rootDir and not the repo-root node_modules.

The Error:

 FAIL   eslint  packages/api/src/index.js
  ● Test suite failed to run

    Cannot find module '/Users/igl/wubba-lubba-dub-dub/packages/api/node_modules/eslint'

      at getLocalESLint (../../node_modules/jest-runner-eslint/build/utils/getLocalESLint.js:9:10)

Contributor guide

Research direction
Investigate how getLocalESLint in getLocalESLint.js resolves the eslint path. Trace the logic to see why it only looks in ./node modules of the package directory instead of the workspace root. Implement a fallback to search the root node modules when the module is not found locally.
Tech stack
javascriptnodejs
Domain
developer experiencetesting
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Node.jsYarnGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55