jenkinsci/jenkinsfile-runner

Cleanup SpotBugs warnings in the codebase

Open

#374 opened on Sep 30, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (1,090 stars) (291 forks)batch import
good first issueinternal

Description

There is a number of SporBugs static analysis warnings in the old parts of the Jenkinsfile Runner codebase. It is possible to see the warnings in the build log. Although there is no severe issues, it would be great to cleanup these warnings and then enforce SpotBugs checks during the build.

List of the current SpotBugs violations: https://ci.jenkins.io/job/jenkinsfile-runner/job/jenkinsfile-runner/job/master/lastSuccessfulBuild/analysis/

Acceptance criteria:

  • All SpotBugs violations need to be either fixed or suppressed
  • FindBugs failOnError is reenabled in the pom.xml

NOTE: Contributors can submit pull requests for particular issues and issue types, no need to fix everything in a single pull request.

Contributor guide

Tech stack
java
Domain
backendbuild system
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaMavenSpotBugs
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Examine the SpotBugs violations list at the provided URL (https://ci.jenkins.io/job/jenkinsfile runner/job/jenkinsfile runner/job/master/lastSuccessfulBuild/analysis/). For each violation, decide whether to fix the code or suppress the warning with justification. After addressing violations, reenable failOnError in pom.xml. Contributors can focus on specific violation types or areas.
Cleanup SpotBugs warnings in the codebase · jenkinsci/jenkinsfile-runner#374 | Good First Issue