[Tech Debt] Update canvas-standalone.test.ts mock state with gamepad properties
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 75/100
- Issue type
- Refactor
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- typescript
- Domain
- testing
Research direction
Open packages/export/tests/runtime/canvas-standalone.test.ts and inspect the mock CanvasRuntimeState object at lines 35-53. Compare it with the properties introduced by PR #588, then run the relevant canvas standalone test or the package test suite. Done means the mock includes the required gamepad state fields and the tests still pass.
Written by the indexing model from the issue text.
Description
Description
The test file's mock CanvasRuntimeState object is missing the previousGamepadButtons and currentGamepadStates properties added in PR #588. This could cause TypeScript errors if tests are expanded.
Location
Changes Needed
Add to the mock state object:
previousGamepadButtons: [[], [], [], []],
currentGamepadStates: [
createEmptyGamepadState(),
createEmptyGamepadState(),
createEmptyGamepadState(),
createEmptyGamepadState(),
],
Found In
PR #588 - fix: Poll gamepad state once per frame in export runtime
Priority
P3-Low - tests still pass, this is preventive maintenance
- Dominant language
- TypeScript
- Stars
- 1
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from jcollard/LuaInTheWeb
-
tech-debt
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
jcollard/LuaInTheWeb#752 ·
-
tech-debt
Difficulty 1/5 Under an hour Newbie friendliness 68/100
jcollard/LuaInTheWeb#690 ·
-
tech-debt
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
jcollard/LuaInTheWeb#518 ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
jcollard/LuaInTheWeb#235 ·
-
tech-debt
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
jcollard/LuaInTheWeb#51 ·
All issues in jcollard/LuaInTheWeb
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Eynzof/Hermes-CN-Desktop#610 ·
-
bug clawsweeper:linked-pr-open clawsweeper:needs-live-repro clawsweeper:no-new-fix-pr impact:message-loss issue-rating: 🐚 platinum hermit P2 regression
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
calcite-components needs triage refactor
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Esri/calcite-design-system#15203 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
danielmiessler/LifeOS#2218 ·