jcjohnson/torch-rnn

Code Review Standards/Pull Request Management

Open

#183 opened on Apr 27, 2017

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Lua (509 forks)github user discovery
help wanted

Repository metrics

Stars
 (2,557 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

We need a standard to review any PRs that come through, any suggestions?

I also move to reject all PRs in the backlog and encourage writers to resubmit. That way we can sort out what is actively being worked on and lessen the load.

Contributor guide

Research direction
Read the existing PR backlog and comment threads to understand current review practices, then propose a formal code review standard.
Tech stack
None
Domain
developer experience
Issue type
Chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75