jazzband/django-taggit

Move verbose_name and verbose_name_plural from TaggedItem to ItemBase

Open

#158 opened on Sep 9, 2013

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (3,433 stars) (624 forks)user submission
enhancementgood first issue

Description

I think it makes sense to move the verbose_name and verbose_name_plural attributes (https://github.com/alex/django-taggit/blob/develop/taggit/models.py#L157) to ItemBase from TaggedItem since if anyone just extends GenericTaggedItemBase or TaggedItemBase will have to define those attributes as well.

Contributor guide

Tech stack
python
Domain
backend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic Django models knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Move the `verbose name` and `verbose name plural` attributes from the `TaggedItem` model at `taggit/models.py` line 157 to the `ItemBase` class. This will ensure that any custom model extending `GenericTaggedItemBase` or `TaggedItemBase` inherits these attributes without needing to redefine them. No new functionality is required; just relocate the code and update any references.