jazzband/django-taggit

Enhacement: Add remove_by_slug() method to TaggableManager

Open

#151 opened on Aug 23, 2013

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (3,433 stars) (624 forks)user submission
enhancementgood first issue

Description

That way it would also be possible to remove tags by providing their unique slugs. Have in mind that people might want to use URLs like .../some-object/tags/my-precious-tag/remove/ to remove a tag.

Adding this method seems easy, but I am reluctant to contribute a PR because I am not sure if I can write correct tests for this code addition. If some guidance and supervision is provided I am willing to try.

Contributor guide

Tech stack
pythondjango
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
PythonDjangodjango taggitDjango testing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
The proposed method `remove by slug()` should be added to `TaggableManager` in `taggit/managers.py`. The existing `remove()` method can serve as a reference. Tests should be added in `taggit/tests.py` following patterns of existing test methods. The author expressed uncertainty about tests, so reviewing test structure and asking for maintainer clarification on expected behavior might be necessary.