jazzband/django-silk

Detect manual sql queries

Open

#80 opened on Oct 8, 2015

View on GitHub
 (8 comments) (14 reactions) (0 assignees)Python (3,958 stars) (319 forks)batch import
enhancementhelp wanted

Description

At the moment silk does its magic by hijacking execute_sql, but this doesn't catch RawQuerySet queries and certainly doesn't catch queries that use the bare cursor.execute, so these appear as time spent in python and the final sql doesn't get logged for nice introspection.

It may be tricky, but it would be nice if silk were able to catch these queries too, possibly by doing the hijacking at a lower level.

Contributor guide

Tech stack
pythonsql
Domain
backenddatabaseperformance
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of Django's SQL execution internalsFamiliarity with monkey patching
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue proposes detecting manual SQL queries (RawQuerySet, cursor.execute) that bypass the existing execute sql hook. Research Django's database backend implementation, focusing on the CursorWrapper class and how connections execute SQL. Consider intercepting at the cursor level or the database driver adapter level. Review any linked PRs or comments for prior attempts. Ensure the solution captures all SQL while maintaining compatibility with existing profiling.