jazzband/django-silk

Cleanup filters form javascript

Closed

#615 opened on Oct 27, 2022

View on GitHubContributor guide
 (4 comments) (0 reactions) (0 assignees)Python (319 forks)batch import
cleanupgood first issue

Repository metrics

Stars
 (3,958 stars)
PR merge metrics
 (PR metrics pending)

Description

There is lot of JavaScript on buttons that should not be present (I think it was to replaced them with easier-to-style div), hence submitFilters() and submitEmptyFilters() are not needed.

Contributor guide

Research direction
Identify all references to submitFilters() and submitEmptyFilters() in JavaScript files and HTML templates, then remove the function definitions and update any event handlers to use a simpler approach.
Tech stack
javascriptpython
Domain
frontend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80