jazzband/django-silk

Cleanup filters form javascript

Open

#615 opened on Oct 27, 2022

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Python (3,958 stars) (319 forks)batch import
cleanupgood first issue

Description

There is lot of JavaScript on buttons that should not be present (I think it was to replaced them with easier-to-style div), hence submitFilters() and submitEmptyFilters() are not needed.

Contributor guide

Tech stack
javascriptpython
Domain
frontend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic JavaScriptDjango template basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
Look at the template files in django silk for filters form (likely in silk/templates/silk/). Find usages of submitFilters() and submitEmptyFilters() JavaScript functions, and identify the buttons that trigger them. Remove those functions and replace the buttons with div elements styled appropriately. Ensure the form still submits correctly without the JS.