jazzband/django-silk

Saving to Request.prof_file raises DataError for paths longer than 251 characters

Open

#201 opened on Jul 31, 2017

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Python (3,958 stars) (319 forks)batch import
help wanted

Description

The decorator is raising a DataError when it tries to store the path of a .prof for any path greater than 251 characters, since the Request.prof_file is 100 300 characters by default, and the filename itself is 41 or 49 characters.

django.db.utils.DataError: value too long for type character varying(300)

In my case, the project path for local development was more than 60 characters at a time the column was 100 chars, which meant the file was saving to disk, but no profile data was being saved to the database. We probably want to at least save the other profile data and log an error, otherwise a long file path breaks profiling altogether.

Contributor guide

Tech stack
pythondjango
Domain
backenddatabase
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Django modelsdatabase error handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
The issue occurs in django silk when saving a .prof file path longer than 251 characters. The fix likely involves either truncating the path, increasing the column size, or catching the DataError to save other profile data and log the error. Examine the model definition in silk/models.py and the relevant saving logic in silk/request.py or similar. Consider adding validation in the Request model or the decorator to handle long paths gracefully.