jazzband/django-silk

raise codec error in execute_sql

Open

#157 opened on Jan 6, 2017

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)Python (319 forks)batch import
bughelp wanted

Repository metrics

Stars
 (3,958 stars)
PR merge metrics
 (PR metrics pending)

Description

The statement would raise codec error when "params" contained non ASCII strings at sql.py: sql_query = q % params It's better to use django's force_text processing to handle it.

Contributor guide

Research direction
Apply Django's force text to params in the SQL query formatting to avoid codec errors with non ASCII strings.
Tech stack
pythondjango
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonDjango
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75