jazzband/django-silk

raise codec error in execute_sql

Open

#157 opened on Jan 6, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (3,958 stars) (319 forks)batch import
bughelp wanted

Description

The statement would raise codec error when "params" contained non ASCII strings at sql.py: sql_query = q % params It's better to use django's force_text processing to handle it.

Contributor guide

Tech stack
pythonsql
Domain
backenddatabase
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
PythonDjango
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
The bug is in sql.py where `sql query = q % params` causes codec errors with non ASCII strings. The fix is to use Django's `django.utils.encoding.force text` to safely handle the params. Look at the existing codebase for similar patterns and add a test case with non ASCII characters to verify the fix.