jazzband/django-silk

SQL queries not ordered correctly w/ MySQL as db backend

Open

#130 opened on Jul 19, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (3,958 stars) (319 forks)batch import
enhancementhelp wanted

Description

In https://github.com/django-silk/silk/blob/master/silk/views/sql.py#L23 the queries are ordered by start_time, which on mysql is defined as start_time datetime DEFAULT NULL.

Datetime without further specification has no microsecond precision in MySQL. As a result, the queries do not order correctly.

In our fork, I implemented a quick hack to address this by using the auto incrementing primary key for ordering.

I'm not sure what the level of MySQL support is and if this sort of change is a good idea for other platforms. Therefore not opening a PR, just opening this issue to track the bug.

Contributor guide

Tech stack
pythonsqlmysql
Domain
backenddatabase
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Django ORMMySQL datetime precision
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the suggested fix from the fork (commit 9855ac2a0e5b27f3f277e94cf5e8fb49e7b50965) which uses the primary key for ordering. Ensure the change does not break other database backends (e.g., PostgreSQL, SQLite) that support microsecond precision. The file to modify is silk/views/sql.py. Consider if a more robust solution like using datetime with microsecond support or ordering by a combination of fields is needed.