jayphelps/core-decorators

The Road to 1.0

Open

#15 opened on Aug 1, 2015

View on GitHub
 (10 comments) (0 reactions) (0 assignees)JavaScript (4,500 stars) (282 forks)batch import
help wantedrequest for comments

Description

Spec compliancy

  • Update to support both the old and new spec (coming in Babel 6)
  • Implement backward compatibility, if possible ???

Add the remaining tests

decorators

  • autobind
  • debounce
  • deprecate
  • nonconfigurable
  • nonenumerable
  • override
  • readonly
  • suppress-warnings

(private/utils)

  • decorate
  • isDescriptor
  • metaFor

Decide if aliases will continue?

I generally do not like aliases. I'd prefer to have all decorators named as a verb and remove the aliases.

  • @​deprecate (alias: @​deprecated)
  • @​mixin (alias: @​mixins)

Slim builds

  • Support rollup via jsnext:main
  • Allow imports of each decorator to not pull in entire library for browserify/webpack users. Most likely via postinstall or similar, aliasing files into the package root so they can import autobind from 'core-decorators/autobind.

Contributor guide

Tech stack
javascript
Domain
testingbuild systemdeveloper experience
Issue type
chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
5
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaScriptBabeltestingmodule bundlers
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
10
Research direction
Review the linked Babel spec (https://github.com/wycats/javascript decorators/pull/36) and the Babel 6 implementation commit. Check the existing test coverage in the repository to identify missing tests for private utilities like decorate and isDescriptor. Additionally, evaluate the feasibility of backward compatibility and decide on alias removal by examining community feedback in the comments.