jasongin/nvs

anyone got this working with fish?

Open

#69 opened on Sep 11, 2017

View on GitHub
 (5 comments) (2 reactions) (0 assignees)JavaScript (2,377 stars) (198 forks)batch import
enhancementhelp wanted

Description

https://fishshell.com/

I had a quick attempt by switching some cases to ifs, but I'm not sure trying for a compatible subset of bash, zsh and fish is a viable (or desirable) approach /shrug

Contributor guide

Tech stack
shell
Domain
clideveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Fish shellBasic shell scripting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue requests Fish shell support for nvs. Examine the current shell scripts (e.g., in src/) to understand how bash and zsh are handled. Comments suggest switching case statements to if statements for compatibility. The solution should maintain existing shell support while adding Fish. Review any linked discussions or PRs for further context.