jaredpalmer/formik

setFieldError does not prevent handleSubmit

Open

#1111 opened on Nov 15, 2018

View on GitHub
 (10 comments) (3 reactions) (0 assignees)TypeScript (34,255 stars) (2,801 forks)batch import
Priority: MediumType: Bughelp wantedpinned

Description

🐛 Bug report

This looks like it may be a possible regression on #317, as I can replicate it in the exact same way.

Current Behavior

After setting an error using setFieldError, the handleSubmit function is successfully fired.

Expected behavior

The form should not submit successfully, as there is an error.

Reproducible example

Click "Set Error". You will then be able to successfully submit. https://codesandbox.io/s/43owlv689

Suggested solution(s)

Your environment

Software Version(s)
Formik 1.3.2
React 16.4.2
TypeScript
Browser Chrome
npm/Yarn 6.1.0
Operating System OSX

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic understanding of ReactFamiliarity with Formik
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The bug is that `setFieldError` does not prevent form submission. Look at the linked PR #317 which introduced `setFieldError` and investigate how `handleSubmit` interacts with error state. The reproducible example in the issue (CodeSandbox) can be used to trace the issue. Check the current Formik source code, especially the `handleSubmit` and `validateField` functions, to understand the expected behavior. Consider adding a check for errors before calling `onSubmit`.