jaredpalmer/formik

Array-helper `insert` adds value to error state

Open

#1,092 opened on Nov 8, 2018

View on GitHub
 (5 comments) (3 reactions) (0 assignees)TypeScript (2,801 forks)batch import
Priority: MediumType: Bughelp wantedpinned

Repository metrics

Stars
 (34,255 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

🐛 Bug report

Current Behavior

When i add an item to a FieldArray using insert the value is also inserted into the errors state (see example below).

Expected behavior

Only insert the value to the values state, not to the errors state.

Reproducible example

https://codesandbox.io/s/v87n4p6023

Your environment

Software Version(s)
Formik 1.3.1
React 16.5.2

Contributor guide

Research direction
Inspect the `insert` method in FieldArray and trace how it modifies state, particularly why it also updates the errors state. Check the relevant source code in Formik's FieldArray component.
Tech stack
reacttypescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactFormik
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75