jaraco/inflect

number_to_words: support for custom comma-separators is broken/incomplete

Open

#176 opened on Feb 13, 2023

View on GitHub
 (4 comments) (1 reaction) (0 assignees)Python (125 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (1,082 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Discovered while refactoring the number_to_words method, as part of reducing complexity of the package in #174:

Using a custom comma argument to number_to_words appears to be supported based on the docstrings, and that would match the corresponding documentation for the EN::Inflect CPAN module that this library is based on.

However: in practice it seems that providing a comma argument (other than the default ,) does not work as expected.

Contributor guide

Research direction
Examine the implementation of number to words in inflect/ init .py, focusing on how the comma argument is handled. Compare with the EN::Inflect CPAN module's documentation and ensure the custom separator is correctly applied. Trace the test cases to verify the expected vs actual behavior.
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45