jaraco/inflect

Words ending in 's' should never be pluralized by adding another 's'

Open

#161 opened on Jun 26, 2022

View on GitHub
 (5 comments) (3 reactions) (0 assignees)Python (125 forks)github user discovery
featurehelp wanted

Repository metrics

Stars
 (1,082 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

stockings -> stockingss jeans -> jeanss sandals -> sandalss

How do I avoid this? I can fix the specific words with defnoun('jeans', 'jeans'), which corrects the result for an isolated string 'jeans' -> 'jeans'.

However, if I try to run plural_noun on 'blue jeans' instead of 'jeans' it then breaks again, returning 'blue jeanss'. I understand this is because 'blue jeans' appears to be a different string from 'jeans', but perhaps it should check the rules for the part of the string it is altering?

I've gotten around this so far by this incredibly hacky 'solution', so any improvement would obviously be immensely appreciated:

            plural = _INFLECT.plural_noun(key, count)
            if plural.endswith('ss'):
                plural = plural[0:-1]

Contributor guide

Research direction
Examine the plural noun function in the inflect library to understand how it handles words ending in 's'. Look for the rule that appends 's' and ensure it checks for existing trailing 's' to avoid duplication. Consider modifying the logic to detect when the last word in a phrase (e.g., 'blue jeans') ends in 's' and apply the correct irregular plural form.
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75