jantimon/favicons-webpack-plugin

Make sure examples work

Open

#295 opened on Jan 9, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (1,198 stars) (226 forks)batch import
help wantedwontfix

Description

Is your feature request related to a problem? Please describe. I downloaded the repo, installed Node.js v10.20.0, and installed dependencies. Then I went to the basic example and ran pnpx webpack serve, and it resulted in an error (probably because there is an old version of webpack-dev-server?).

Describe the solution you'd like The examples should include dependencies like webpack, webpack-cli, and webpack-dev-server, and have scripts in package.json for starting server and building. They should also work with any node version >= the minimum node version.

Describe alternatives you've considered Using the favicon option in HtmlWebpackPlugin.

Additional context I'm using nodist and pnpm on Windows 10.

Contributor guide

Tech stack
javascriptnodejs
Domain
documentationdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Node.jsnpm or pnpmwebpack basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Examine the examples directory structure in the repository. Each example likely has its own package.json that may be missing dependencies like webpack, webpack cli, and webpack dev server. Add these dependencies and create scripts for 'start' and 'build' using webpack commands. Ensure compatibility with Node.js versions >= the project's minimum. Verify the examples run successfully after changes.