jantimon/favicons-webpack-plugin

Incompatible with webpack-subresource-integrity

Open

#279 opened on Jul 29, 2021

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (226 forks)batch import
help wantedwontfix

Repository metrics

Stars
 (1,198 stars)
PR merge metrics
 (Avg merge 8h 36m) (3 merged PRs in 30d)

Description

Current behaviour 💣

When using favicons-webpack-plugin in webpack@^5.0.0, webpack-subresource-integrity throws an error.

Expected behaviour ☀️

favicons-webpack-plugin should complete even while using webpack-subresource-integrity; preferably with included integrity hashes.

Reproduction Example 👾

Setup latest webpack with favicons-webpack-plugin and webpack-subresource-integrity.

Environment 🖥

Node.js v16.5.0 linux 5.13.5-arch1-1

Contributor guide

Research direction
Investigate the conflict between favicons webpack plugin and webpack subresource integrity (SRI). The issue likely stems from how favicons webpack plugin modifies HTML assets via html webpack plugin, which may interfere with SRI hash injection. Start by reviewing the source code of favicons webpack plugin (especially how it integrates with html webpack plugin) and the SRI plugin's documentation/issue tracker. Look for any known incompatibilities or hooks that might be missing. Consider reproducing the issue with a minimal webpack config to pinpoint the exact error. The maintainers may need to adjust asset handling to ensure SRI hashes are computed correctly.
Tech stack
javascriptnodejs
Domain
build systemtooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Needs investigation
Prerequisites
Understanding of webpack plugin systemFamiliarity with html webpack pluginKnowledge of subresource integrity
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30