janeczku/rancher-letsencrypt

Don't obtain cert if one already exists (persist LE User)

Open

#50 opened on Dec 13, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Go (110 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (324 stars)
PR merge metrics
 (PR metrics pending)

Description

If I spawn a LE stack, it gets a certificate and stores it in the certificate store. If I then remove the stack and recreate it with the same settings, it will 'Found existing certificate 'cake' in Rancher' but still go out and grab a fresh one from LetsEncrypt.

For production usage, this isn't safe. I never want to pull a new certificate unnecessarily unless the previous one is about to expire (or maybe if I enable that functionality and in sandbox mode). If it's a worry about populating the local volume/directory with the certificate, we should pull the present one from the Certificate Store and save it.

Contributor guide

Research direction
Investigate the certificate storage and retrieval logic in the LE stack to ensure that an existing valid certificate is reused instead of obtaining a new one.
Tech stack
godocker
Domain
backenddevopsinfrastructure
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoDocker
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60