jakearchibald/svgomg

Improve keyboard navigation

Open

#304 opened on Sep 22, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,473 stars) (474 forks)batch import
bughelp wanted

Description

Currently, keyboard navigation is broken in many places.

As a first step, I think we should switch to buttons when possible (I have a WIP patch), and then see how we can solve the remaining issues with material tabs and the floating buttons getting focused when they are not being shown.

I mark this as a bug because IMHO this is an important accessibility issue.

Contributor guide

Tech stack
javascripthtmlcss
Domain
accessibilityfrontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic HTML accessibilitykeyboard navigation concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The issue describes a WIP patch by the author for switching to buttons. Investigate the current codebase (likely in src/ or similar) to identify where non button elements are used for interactive controls. Implement the changes to use buttons where appropriate, and then address remaining issues with material tabs and floating buttons that receive focus when hidden. Check for any existing PRs or comments related to this issue.