jaegertracing/jaeger

[test] Flaky test TestPasswordFromFile in plugin/storage/es/factory_test.go

Open

#4,743 opened on Sep 10, 2023

View on GitHub
 (9 comments) (0 reactions) (0 assignees)Go (18,974 stars) (2,326 forks)batch import
buggood first issuehelp wanted

Description

https://github.com/jaegertracing/jaeger/actions/runs/6134973238/job/16648278200?pr=4742#step:7:4523

One strange thing I noticed in the output that the very last logged request to the server was with Basic Auth string looking like the first password, not the second password, as if the request with the second password was made but then someone again made a request with the old one. I wonder if the es.Client object can continue sending pings to the server if it's not Close-ed (which we don't do).

Contributor guide

Tech stack
goelasticsearch
Domain
testingbackend
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
GotestingElasticsearch
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the flaky test TestPasswordFromFile in plugin/storage/es/factory test.go. Review the CI run logs linked in the issue to identify the pattern. Consider whether the es.Client is not properly closed, causing lingering connections with old credentials. Look for any related PRs or comments that discuss the issue. Attempt to reproduce the flakiness locally.