jackwener/maka-agent

refactor(cli): remove dead outcome helpers and unify MakaRunOutcome classification

Closed

#3,088 opened on Aug 15, 2026

View on GitHubContributor guide
 (1 comment) (0 reactions) (1 assignee)TypeScript (0 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (1 star)
PR merge metrics
 (No merged PRs in 30d)

Description

Problem

Three dead / duplicated outcome paths in packages/cli:

  1. sandbox-boundary-failure.ts — invocationHasSandboxBoundaryFailure / invocationRecoveredSandboxBoundaryFailure have zero callers (they are the last consumers of the removed runtime's InvocationResult). The live sibling sessionEventSandboxBoundaryFailureReason must stay.
  2. MakaRunOutcome is computed twice from two sources in runtime-host-run-command.ts — a live TurnOutcomeAccumulator (SessionEvent stream) and a stored-message classifier (outcomeFromStoredTurn / storedSandboxBoundaryOutcome) whose vocabularies already diverge (aborted/runtime_error vs errorClass ?? abortSource ?? status).
  3. Dead exports with no callers: formatResumeHint, cleanRecapText/RECAP_INSTRUCTION, runMakaTextCli, colorDiffRow.

Desired outcome

One MakaRunOutcome classifier parameterized over its source, dead helpers removed, dead exports dropped.

Alternatives or workarounds

Leave the divergence; the stored-message path already produces different failure classes from the live path.

Acceptance

  • invocationHasSandboxBoundaryFailure / invocationRecoveredSandboxBoundaryFailure removed; sessionEventSandboxBoundaryFailureReason retained
  • One outcome classifier shared by the live and stored-message paths
  • Dead exports removed
  • maka run and maka run --graph exit codes pinned by CLI tests; typecheck and Biome pass

Related

  • #3034, #3035 (prior runtime path removals)

Contributor guide

Research direction
Examine the two files under packages/cli mentioned in the issue. Search for usages of the dead helpers and exports to confirm they are unused. Compare the two MakaRunOutcome definitions and design a single parameterized classifier. Run the CLI tests to verify exit codes, and make sure typecheck and Biome pass.
Tech stack
typescript
Domain
cli
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75