zsh-users/zsh-completions

cmake completion for --find-package lacks required -D arguments

Open

#593 opened on 2018年9月3日

GitHub で見る
 (2 comments) (0 reactions) (0 assignees)Shell (6,175 stars) (693 forks)batch import
Bughelp wanted

説明

The current cmake completion does not suggest the -D arguments that are required when running --find-package. See also stackoverflow.

Essentially, when one uses --find-package, also -DNAME must be set. Otherwise cmake complains:

CMake Error at /usr/share/cmake-3.12/Modules/CMakeFindPackageMode.cmake:33 (message):
  Name of the package to be searched not specified.  Set the CMake variable
  NAME, e.g.  -DNAME=JPEG .

Further down the line one gets

CMake Error at /usr/share/cmake-3.12/Modules/CMakeFindPackageMode.cmake:37 (message):
  COMPILER_ID argument not specified.  In doubt, use GNU.

then

CMake Error at /usr/share/cmake-3.12/Modules/CMakeFindPackageMode.cmake:41 (message):
  LANGUAGE argument not specified.  Use C, CXX or Fortran.

and eventually

CMake Error at /usr/share/cmake-3.12/Modules/CMakeFindPackageMode.cmake:45 (message):
  MODE argument not specified.  Use either EXIST, COMPILE or LINK.

I.e. --find-package implies that -DNAME=, -DLANGUAGE=, -DCOMPILER_ID= and -DMODE= are provided. The possible values are spelled out in the error messages above.

I don't see how to add that myself to the current completion (given time constraints and priorities).

コントリビューターガイド

技術スタック
shell
領域
cli
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
basic zsh completioncmake find package knowledge
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
60
調査方針
Look at the existing cmake completion file (likely ` cmake`) in the repository. Add logic to suggest ` DNAME=`, ` DCOMPILER ID=`, ` DLANGUAGE=`, and ` DMODE=` options when ` find package` is present. The possible values are given in the error messages: NAME can be any package name, COMPILER ID can be GNU, Clang, etc., LANGUAGE can be C, CXX, Fortran, MODE can be EXIST, COMPILE, LINK. You may need to parse the existing completion to understand how to add these dynamically.