zhanghai/MaterialRatingBar

Stars not reflecting user input

Open

#28 opened on 2017年11月17日

GitHub で見る
 (7 comments) (7 reactions) (1 assignee)Java (1,947 stars) (206 forks)batch import
bughelp wanted

説明

I think this is a general issue with the RatingBar for Android, but wanted to post here to be sure as I couldn't find a definitive answer.

We have the MaterialRatingBar in our app (love it btw), using width=match_parent.

On some devices, when the user taps 1 star, the 2nd star updates. If they tap the 2nd star, the 3rd updates etc. User can never select 1 star and the star they select is never the correct one.

Samsung devices seem to suffer the worst with this issue. It works fine as well on plenty of devices. If we get rid of match_parent, it seems to work on all devices too.

コントリビューターガイド

技術スタック
androidjava
領域
mobile
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
blocked
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Android development experienceCustom View measurement
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
45
調査方針
Review the MaterialRatingBar source code, particularly the onTouchEvent and onMeasure methods, to understand how touch coordinates are translated to star selection. Examine the issue comments for device specific details and any suggested workarounds. Test with different layout widths to reproduce the bug on a Samsung device. Consider whether the issue lies in touch coordinate calculation when the view width is set to match parent.
Stars not reflecting user input · zhanghai/MaterialRatingBar#28 | Good First Issue