Drop Futile BUILD_ASSERTs in tmc5xxx series · zephyrproject-rtos/zephyr

(2 件のコメント) (1 件のリアクション) (1 人の担当者)C (9,144 件のフォーク)batch import

Good first issuearea: Stepper

Repository metrics

Stars: (15,249 個のスター)
PR merge metrics: (平均マージ 4d 21h) (30d で 1,000 merged PRs)

説明

Summary

stallguard_threshold_velocity is actually part of adi,tmc5xxx-stepper-ctrl bindings. https://github.com/zephyrproject-rtos/zephyr/blob/cdb58275997595faa129ca83ed0cfeb37542026b/dts/bindings/stepper/adi/adi%2Ctmc50xx-stepper-ctrl.yaml#L10 https://github.com/zephyrproject-rtos/zephyr/blob/cdb58275997595faa129ca83ed0cfeb37542026b/drivers/stepper/adi_tmc/tmc51xx/tmc51xx_stepper_ctrl.c#L493

However, couple of other drivers in the tmc5xxx series do BUILD_ASSERT on this property. The ASSERT never actually happens since it's guarded by a COND_CODE_1, which would never be tree, hence it's actually futile.

https://github.com/zephyrproject-rtos/zephyr/blob/cdb58275997595faa129ca83ed0cfeb37542026b/drivers/stepper/adi_tmc/tmc51xx/tmc51xx.c#L528-L530

Describe the solution you'd like

Drop the ASSERTs listed below.

Alternatives

No response

Additional Context

No response

コントリビューターガイド

調査方針: The issue involves removing three futile BUILD ASSERT macros from files: drivers/stepper/adi tmc/tmc51xx/tmc51xx.c (lines 528-530), drivers/stepper/adi tmc/tmc51xx/tmc51xx stepper driver.c (lines 205-207), and drivers/stepper/adi tmc/tmc50xx/tmc50xx stepper driver.c (lines 170-172). The asserts are guarded by COND CODE 1 on a property that never exists, so they are dead code. The fix is to delete those lines. The issue is assigned but has no open PR, so check assignee status before starting.
技術スタック: c
領域: backend
Issue 種別: リファクタリング
難度: 2
推定時間: 1時間未満
活動状況: ブロック中
明確さ: 明確
前提条件: C programming
初心者向け度: 40