zalmoxisus/redux-devtools-extension

Sets aren't properly diffed or displayed

Open

#452 opened on 2018年1月30日

GitHub で見る
 (1 comment) (8 reactions) (0 assignees)JavaScript (1,074 forks)batch import
help wantedmonitor

Repository metrics

Stars
 (13,478 stars)
PR merge metrics
 (30d に merged PR はありません)

説明

Just wanted to make you aware of a possible bug. When passing a new set as a key of the initial state:

{
  items: new Set()
}

and then later adding to the set like so:

const newItems = new Set(state.items)
newItems.add("newItem")
return {...state, items: newItems}

the redux devtools evaluates the diff as no change, while logging the state shows that an item was added.

Let me know if you want any more details about this bug. I have a workaround that I'm using to log the items when needed, but thought you might want to know.

コントリビューターガイド