zalmoxisus/redux-devtools-extension

Sets aren't properly diffed or displayed

Open

#452 opened on 2018年1月30日

GitHub で見る
 (1 comment) (8 reactions) (0 assignees)JavaScript (13,478 stars) (1,074 forks)batch import
help wantedmonitor

説明

Just wanted to make you aware of a possible bug. When passing a new set as a key of the initial state:

{
  items: new Set()
}

and then later adding to the set like so:

const newItems = new Set(state.items)
newItems.add("newItem")
return {...state, items: newItems}

the redux devtools evaluates the diff as no change, while logging the state shows that an item was added.

Let me know if you want any more details about this bug. I have a workaround that I'm using to log the items when needed, but thought you might want to know.

コントリビューターガイド

技術スタック
javascriptreact
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Understanding of Redux DevTools extensionFamiliarity with JavaScript Set and object diffing
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
30
調査方針
Investigate how the Redux DevTools extension computes state diffs. The issue likely lies in the diffing logic that may not handle non plain objects like Set. Look for files related to state comparison or diffing, such as 'src/browser/extension/inject/diff.js' or similar. Check if the extension uses JSON.stringify or a custom deep equal function that fails on Set. Consider implementing a custom diff that handles Set by converting to array or using iterator.
Sets aren't properly diffed or displayed · zalmoxisus/redux-devtools-extension#452 | Good First Issue