yegor256/takes
Refactor TkHtmlTest to improve structure and edge case coverage (relates to #1408)
オープン
#1,435 opened on 2025/07/24
enhancementhelp wanted
Repository metrics
- Stars
- (875 個のスター)
- PR merge metrics
- (平均マージ 95d 2h) (30d で 22 merged PRs)
説明
Improve and Refactor TkHtmlTest for Maintainability and Coverage (related to #1408)
The current implementation of TkHtmlTest can be improved in the following ways:
-
Duplication: Each test manually builds a nearly identical expected response using
Joined(..., body). This can be extracted into a helper method or reused variable. -
Edge Cases Missing:
- No tests for null or empty input.
- No assertion that
Content-TypeandContent-Lengthheaders are semantically correct (not just matched by string).
-
Structure Validation:
- Could add a test to verify that the body actually starts/ends with
<html>tags to ensure semantic HTML is passed.
- Could add a test to verify that the body actually starts/ends with
-
Test Readability:
- Introduce
@DisplayNameannotations or comment grouping to make intent clearer.
- Introduce
A can provide a PR if the maintainers agree.