yarnpkg/yarn

Retain custom command line flags while installation

Open

#3,307 opened on 2017年5月2日

GitHub で見る
 (5 comments) (1 reaction) (0 assignees)JavaScript (41,514 stars) (2,731 forks)batch import
cat-featurehelp wantedtriaged

説明

Do you want to request a feature or report a bug? Feature

What is the current behavior? Custom CLI flags are dropped. yarn install is the same as yarn install --some-flag=value node-gyp bindings can utilize the custom flags to change the build behavior for addons.

If the current behavior is a bug, please provide the steps to reproduce. I have been working on a fork of lovell/sharp, implementing few features that I needed. The current upstream can automatically detect the correct C++ ABI to be used, while the fork at gargsms/sharp is lagging behind, and still needs the custom flag --sharp-cxx11=1 during npm install. On systems with the gcc5.1+ installed available, npm install will result in a core dump, and the process failing with SIGABRT, while npm install --sharp-cxx11=1 will result in the correct behavior. This has been reported here

What is the expected behavior? Custom flags are retained and passed to other processes in the install/build pipeline

Please mention your node.js, yarn and operating system version.

$ node -v
v6.9.5

$ yarn --version
0.24.0-20170502.1431

$ uname -ioprsv
Linux 4.4.0-75-generic #96-Ubuntu SMP Thu Apr 20 09:56:33 UTC 2017 x86_64 x86_64 GNU/Linux

コントリビューターガイド

技術スタック
nodejsshell
領域
clibuild systemdeveloper experience
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Understanding of Yarn's install lifecycleFamiliarity with Node.js command line flags
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
30
調査方針
To implement this feature, examine how yarn parses and forwards command line flags during the install command. Look at the code in src/cli/commands/install.js and the package installation pipeline where child processes like node gyp are spawned. Identify where flags are currently filtered or dropped, and propose a mechanism to preserve custom flags that are not recognized by yarn, passing them through to the underlying build steps. Check the existing test suite for flag handling to understand the expected behavior.