yarnpkg/yarn

Bad file paths when publishing on Windows (backslash in package file paths)

Open

#3,031 opened on 2017年4月2日

GitHub で見る
 (1 comment) (2 reactions) (0 assignees)JavaScript (41,514 stars) (2,731 forks)batch import
cat-buggood first issueneeds-confirmationos-windowstriaged

説明

Do you want to request a feature or report a bug? bug

What is the current behavior? Packages published via yarn publish, on Windows, seem to use backslash as a path separator for file paths. This becomes a problem when these packages are added on *nix systems where the backslash is interpreted as part of the filename and not as a directory separator.

So if a package is published, on Windows, with the following file path: dist/test.min.js When added, on a *nix system, the file is downloaded and created as: dist\test.min.js

If the current behavior is a bug, please provide the steps to reproduce.

  1. Publish a package on a Windows system (yarn publish blah)
  2. Add that package as dependency to a project via yarn add blah on a *nix system

What is the expected behavior? Directory structure of published folder from a Windows system will be retained when adding package on *nix system.

Please mention your node.js, yarn and operating system version. System used to publish:

  • node v6.9.1
  • yarn v0.21.3
  • Windows 10 Home v1607 (64-bit)

System used to add:

  • node v7.8.0
  • yarn v0.21.3
  • Ubuntu 14.04

コントリビューターガイド

技術スタック
nodejs
領域
release
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Node.js basicsCross platform path handling
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
65
調査方針
The issue is about backslashes in file paths when publishing a package on Windows. To fix, locate the code that generates the file paths for the package tarball (likely in the packer module). Ensure that all paths are normalized to use forward slashes before writing to the tarball. Also check if the installation code correctly handles forward slashes on Windows. Consult the existing tests for cross platform path handling and consider adding a new test for this scenario.