yarnpkg/yarn

yarn install --flat should probably show the reason why a package is required

Open

#3,013 opened on 2017年3月29日

GitHub で見る
 (3 comments) (15 reactions) (0 assignees)JavaScript (41,514 stars) (2,731 forks)batch import
cat-featuregood first issuehelp wantedhigh-prioritytriaged

説明

Do you want to request a feature or report a bug?

Feature

What is the current behavior?

When running yarn install --flat, yarn may ask multiple questions asking to resolve package versions. However, as it goes deeper down the rabbit whole, it may be beneficial to provide the user with more info as to why particular versions are presented as choices.

If the current behavior is a bug, please provide the steps to reproduce.

See dependencies from a current project. Testing-related dependencies are, sadly, outdated, other versions are more or less recent (no more than one week old :) )

Running yarn install --flat with the the deps in the linked file will ask numerous questions for almost every single dependency in the file. A sample:

info Unable to find a suitable version for "inferno", please choose one by typing one of the numbers below:
  1) "inferno@1.4.1, inferno@^1.4.1, inferno@^1.1.1" which resolved to "1.4.1"
  2) "inferno@^1.5.4" which resolved to "1.5.4"
Answer?

info Unable to find a suitable version for "babel-core", please choose one by typing one of the numbers below:
  1) "babel-core@6.23.1" which resolved to "6.23.1"
  2) "babel-core@^6.24.0, babel-core@^6.0.0" which resolved to "6.24.0"
Answer?

...etc...

and nested dependencies:

info Unable to find a suitable version for "ansi-styles", please choose one by typing one of the numbers below:
  1) "ansi-styles@^2.2.1" which resolved to "2.2.1"
  2) "ansi-styles@~1.0.0" which resolved to "1.0.0"
  3) "ansi-styles@^3.0.0" which resolved to "3.0.0"
Answer?

info Unable to find a suitable version for "jsesc", please choose one by typing one of the numbers below:
  1) "jsesc@^1.3.0" which resolved to "1.3.0"
  2) "jsesc@~0.5.0" which resolved to "0.5.0"
Answer?

... etc ...

What is the expected behavior?

It would be nice to find out:

  • why these particular versions were selected
  • why these particular nested dependencies are required and why the conflict (a regular install generates 627 directories in node_modules, so there's no way of knowing a particular dependency at a glance)

The best way would probably be having h as an option to Answer? which would detail the whys and the hows

Please mention your node.js, yarn and operating system version.

> node -v
v6.9.1
> yarn -V
0.21.3
> system_profiler SPSoftwareDataType
      System Version: macOS 10.12.3 (16D32)
      Kernel Version: Darwin 16.4.0

コントリビューターガイド

技術スタック
javascript
領域
clideveloper experience
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Basic Node.js knowledgeUnderstanding of Yarn's dependency resolution
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
50
調査方針
Examine the code path for `yarn install flat` in the Yarn codebase, likely in `src/package resolver.js` or `src/reporters/`. The feature request suggests adding a help option ('h') during version prompts that would explain why each version is required. Investigate how the conflict resolution works and where the prompt is generated. Consider modifying the prompt to optionally display the dependency chain that leads to each version requirement.