yarnpkg/yarn

An unexpected error occurred: "Commit hash required".

Open

#2,976 opened on 2017年3月23日

GitHub で見る
 (33 comments) (18 reactions) (1 assignee)JavaScript (41,514 stars) (2,731 forks)batch import
cat-bughelp wantedneeds-confirmationtriaged

説明

I've got a project, that has been running fine for months, where suddenly adding/installing eth-lightwallet fails during fetching packages with An unexpected error occurred: "Commit hash required".

Suddenly is defined as between March 21st, 9:51AM CET - March 22nd, 5:30PM CET with a commit that did not touch the package.json or lock files (just a css and html fix)

I've tried:

  • changing node version 7.7.4 and 7.7.1 (on 7.7.1 it worked before without question)
  • removing all caches, npm_modules, lockfiles
  • it fails both on a linux (alpine and debian) ci docker image, and on OSX
  • created a new project and added it. this worked, so it's my dependency set that breaks it
  • it appears to be related to bignumber.js in the dependencies, so tried a lot of different formats in https://github.com/roderik/eth-lightwallet.git
  • added if (!commit) console.log(_this2) to my git-fetcher.js line 113 and installed using yarn add https://github.com/roderik/eth-lightwallet.git --verbose --network-concurrency 1 --force Result: https://gist.github.com/roderik/f5ff6abfcdcdb364f2a5327016317de0 and the error log, but this does not show a reason for the commit hash to be empty
  • it installs fine with npm, so it's my dependencies + yarn

I'm stumped and reverted to yarn install || npm i on my ci, but this is not really the way it's supposed to be.

コントリビューターガイド

技術スタック
javascriptnodejs
領域
backendtooling
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
4
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
over 1 week
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
active
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
needs investigation
前提条件
Node.js basicsYarn internalsGit protocolDebugging JavaScript
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
20
調査方針
The bug occurs when installing eth lightwallet via Yarn, with 'Commit hash required' error. Debugging shows the issue is in git fetcher.js line 113 where commit hash is empty. Since npm installs fine, the root cause is in Yarn's git fetching logic. Investigate the git fetcher module, specifically how commit hash is resolved for dependencies. Look at the eth lightwallet package.json and its dependency bignumber.js. Consider whether Yarn's git fetching has a regression related to how it handles tags or branches vs. commits.