Yarn does not remove old package name from yarn.lock when install from git repo · yarnpkg/yarn#2840

(6 comments) (5 reactions) (0 assignees)JavaScript (41,514 stars) (2,731 forks)batch import

cat-buggood first issuehelp wantedtriaged

説明

yarn version 0.21.3

Do you want to request a feature or report a bug? bug

What is the current behavior? When install new package which is the same name as the old one from git repo, the old package in yarn.lock does not disappear.

the steps to reproduce :

npm init -y
yarn add https://github.com/FF-Mercurial/ug
yarn add https://github.com/kokororin/ug

see yarn.lock:

"ug@https://github.com/FF-Mercurial/ug":
  version "1.0.0"
  resolved "https://github.com/FF-Mercurial/ug#5a0400908d4a2b3ad8ce6d9a4c42fd3d3640983c"
  dependencies:
    escodegen "^1.6.1"
    esprima "^2.5.0"
    uglify-js "^2.4.24"

"ug@https://github.com/kokororin/ug":
  version "1.0.0"
  resolved "https://github.com/kokororin/ug#d38db29b6ce10037d235875c3b5b56b97a36877e"
  dependencies:
    escodegen "^1.6.1"
    esprima "^2.5.0"
    uglify-js "^2.4.24"

What is the expected behavior? The old package in yarn.lock should be removed.

Please mention your node.js, yarn and operating system version.

$ ver
Microsoft Windows [版本 6.1.7601]

$ node -v && yarn --version
v7.5.0
0.21.3

コントリビューターガイド

技術スタック: javascriptnodejs
領域: tooling
Issue 種別: bug
難度: 3
推定時間: 1-3 hours
活動状況: stale
明確さ: clear
前提条件: Basic understanding of yarn and yarn.lockFamiliarity with git dependencies
初心者向け度: 50
調査方針: Investigate the yarn.lock resolution logic when adding a package from a git URL. The bug occurs because yarn does not remove the old entry when a package with the same name is replaced. Look at the lockfile module, likely in `src/lockfile/` or similar. Check the comments on the issue for any maintainer suggestions.