yarnpkg/yarn

Yarn ignores invalid command line arguments

Open

#2,600 opened on 2017年1月31日

GitHub で見る
 (4 comments) (8 reactions) (0 assignees)JavaScript (41,514 stars) (2,731 forks)batch import
cat-featuregood first issuehelp wantedhigh-prioritytriaged

説明

Do you want to request a feature or report a bug?

A bug.

What is the current behavior?

$ yarn install --parsing-command-line-arguments-is-hard
yarn install v0.19.1
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...
[...]
Done in 12.71s.

If the current behavior is a bug, please provide the steps to reproduce.

yarn silently ignores unknown command line arguments. That's a usability problem, i.e. when users mistype an argument, the command silently proceeds but then fails to behave as expected, leaving a puzzled user. Combined with potentially dangerous arguments, this can be a bigger problem. Imagine installing an untrusted package that you'd like to inspect for security reasons, but misstyping --ignore-scripts.

What is the expected behavior?

$ yarn install --fried-chicken
yarn install v0.19.1
error Unknown argument "--fried-chicken".

Please mention your node.js, yarn and operating system version.

Node v5.3.0, Ubuntu.

コントリビューターガイド

技術スタック
javascriptnodejs
領域
clideveloper experience
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
JavaScriptCLI argument parsing
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
30
調査方針
Examine the CLI argument parsing implementation in Yarn's codebase, focusing on files like `src/cli/index.js` or the command parser. Identify where unknown arguments are silently ignored and add validation to throw an error. Since the 1.x line is frozen, consider if the fix should be directed to the Yarn Berry repository. No existing PRs are linked.